Add the ability to not remap unit files #54
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'd like to have the ability to copy unit files without remapping them. For this PR MobileNativeFoundation#53 we still need to read in the unit files but not mutate the material. This PR just removes the requirement on "remap" arg.
jerrymarino
added a commit
to bazel-ios/rules_swift
that referenced
this pull request
Feb 22, 2021
This was a workaround for MobileNativeFoundation/index-import#54
|
in this case wouldn't you be better off just calling also you'll have to sign the cla |
|
@jerrymarino Thinking about this more, this change only really makes sense once we have something like #53. Can this just be part of that PR instead? |
jerrymarino
added a commit
to bazel-ios/rules_swift
that referenced
this pull request
Feb 23, 2021
This was a workaround for MobileNativeFoundation/index-import#54
|
@brentleyjones sure, I can add it to #53 - is this something that you think fits into this repo? I'd like to use the codepath I added there in Bazel and think this repo makes a nice "Swiss army knife" for indexes! |
|
I think so, yes. |
jerrymarino
added a commit
to bazel-ios/rules_swift
that referenced
this pull request
Feb 25, 2021
This was a workaround for MobileNativeFoundation/index-import#54
|
@brentleyjones thanks for getting this in 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to have the ability to copy unit files without
remapping them. For this PR #53
we still need to read in the unit files but not mutate the material.
This PR just removes the requirement on "remap" arg.