Expose converter via StoreBuilder.from() function #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbrawner
commented
Dec 18, 2023
| RealStoreBuilder(fetcher, sourceOfTruth, memoryCache) | ||
| RealStoreBuilder<Key, Network, Output, Network>(fetcher, sourceOfTruth, memoryCache) | ||
|
|
||
| fun <Key : Any, Network : Any, Output : Any, Local: Any> storeBuilderFromFetcherSourceOfTruthMemoryCacheAndConverter( |
There was a problem hiding this comment.
I followed the existing conventions for naming this function, but just out of curiosity: why not use a single function with default arguments?
Signed-off-by: William Brawner <[email protected]>
wbrawner
force-pushed
the
converter-store-builder
branch
from
1b7333d
to
936f701
Compare
matt-ramotar
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #554
Description
This just exposes the
converterargument in theRealStoreBuilderclass so that one can provide custom implementations of it. I'd be happy to update the docs as well, if I could be directed to where I can find the sources for them.Type of Change
Test Plan
This didn't seem to warrant any new tests, but I could add them if desired.
Checklist:
Before submitting your PR, please review and check all of the following: