Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xcFrameworks: Set force flag on static libs #739

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dasisdormax
Copy link

Description

This sets the force flag on static libraries included from an xcFramework.

My Reasoning

My project uses ZSTD included as a static library and I recently tried to switch it from a regular lib to an xcframework (for arm-simulator support). Without this, the ZSTD symbols would be missing from the binary.

This is the minimal implementation that works with my setup. If you think a 'force' option on the xcframework path is needed instead, I could implement that instead.

@dasisdormax dasisdormax force-pushed the force-xcframework-static-libs branch from c324aaf to cd0c98f Compare July 29, 2023 05:24
@dkimitsa
Copy link
Contributor

dkimitsa commented Sep 2, 2023

hi, we should not force all static libs unconditionally.
for classic libs there was standalone flag for this.
To make sure you symbols are not stripped you should keep them as export symbols, here is an example for FB:
https://github.com/dkimitsa/robovm-robopods/blob/alt/facebook/ios-core/src/main/robopods/META-INF/robovm/ios/robovm.xml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants