-
-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show all connected devices in the status bar #1888
Conversation
Build for this pull request: |
Build for this pull request: |
Build for this pull request: |
Build for this pull request: |
Why remove the status icon? I think people are used to looking for that. |
The only thing that controlled the status icon was having a non-zero number of modules connected. It doesn't convey any information beyond "at least one module is connected" and is a constant source of posts in Discord from people who only use joysticks wondering why there's a warning showing. Even if I did change it to hide if at least one joystick was connected, then it would likely always be hidden. The new UI directly shows you what's connected in each category. The icon just leads to confusion, so it's gone :) |
@neilenns I really would like to keep the green check mark if at least one of any of the supported devices is connected and the exclamation mark in case none are detected, no boards, no josticks no midi boards |
@DocMoebiuz It's back. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The on i18n change. "Nichts" vs "Keine" - i added it as a suggestion.
Co-authored-by: Sebastian M <[email protected]>
Build for this pull request: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, man! Thanks
Fixes #1887
Changes the "Modules:" dropdown in the status bar to a "Connected devices" dropdown that has submenus for Joysticks, MIDI devices, and Modules.
If no devices of a given type are connected a disabled "None" shows in the appropriate submenu.
Also tweaked the sim status label to drop the colon and lowercase status so it is consistent with the other status bar labels.