Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show all connected devices in the status bar #1888

Merged
merged 8 commits into from
Jan 5, 2025

Conversation

neilenns
Copy link
Contributor

@neilenns neilenns commented Dec 26, 2024

Fixes #1887

Changes the "Modules:" dropdown in the status bar to a "Connected devices" dropdown that has submenus for Joysticks, MIDI devices, and Modules.

image

If no devices of a given type are connected a disabled "None" shows in the appropriate submenu.

image

Also tweaked the sim status label to drop the colon and lowercase status so it is consistent with the other status bar labels.

@neilenns neilenns marked this pull request as ready for review December 26, 2024 15:40
@neilenns neilenns requested a review from DocMoebiuz as a code owner December 26, 2024 15:40
Copy link

Build for this pull request:
MobiFlightConnector.zip

Copy link

Build for this pull request:
MobiFlightConnector.zip

@neilenns neilenns changed the title Add a joystick dropdown to the status bar Show all connected devices in the status bar Dec 27, 2024
Copy link

Build for this pull request:
MobiFlightConnector.zip

Copy link

Build for this pull request:
MobiFlightConnector.zip

@DocMoebiuz
Copy link
Collaborator

Why remove the status icon? I think people are used to looking for that.
I would also have to check the status icon... does it consider missing devices in current config... i am not sure.

@neilenns
Copy link
Contributor Author

Why remove the status icon? I think people are used to looking for that. I would also have to check the status icon... does it consider missing devices in current config... i am not sure.

The only thing that controlled the status icon was having a non-zero number of modules connected. It doesn't convey any information beyond "at least one module is connected" and is a constant source of posts in Discord from people who only use joysticks wondering why there's a warning showing.

Even if I did change it to hide if at least one joystick was connected, then it would likely always be hidden.

The new UI directly shows you what's connected in each category. The icon just leads to confusion, so it's gone :)

@DocMoebiuz
Copy link
Collaborator

@neilenns I really would like to keep the green check mark if at least one of any of the supported devices is connected and the exclamation mark in case none are detected, no boards, no josticks no midi boards

@neilenns
Copy link
Contributor Author

neilenns commented Jan 4, 2025

@DocMoebiuz It's back.

Copy link
Collaborator

@DocMoebiuz DocMoebiuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The on i18n change. "Nichts" vs "Keine" - i added it as a suggestion.

Copy link

github-actions bot commented Jan 4, 2025

Build for this pull request:
MobiFlightConnector.zip

Copy link
Collaborator

@DocMoebiuz DocMoebiuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, man! Thanks

@DocMoebiuz DocMoebiuz merged commit 694f418 into MobiFlight:main Jan 5, 2025
1 check passed
@DocMoebiuz DocMoebiuz mentioned this pull request Jan 5, 2025
@DocMoebiuz DocMoebiuz added the enhancement Improvement of an existing feature label Jan 5, 2025
@DocMoebiuz DocMoebiuz added feature A new feature and removed enhancement Improvement of an existing feature labels Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a joysticks dropdown to the status bar
2 participants