Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add setting to control minimize on autorun #1318

Merged
merged 3 commits into from
Oct 17, 2023
Merged

Add setting to control minimize on autorun #1318

merged 3 commits into from
Oct 17, 2023

Conversation

neilenns
Copy link
Contributor

@neilenns neilenns commented Oct 12, 2023 •
edited by DocMoebiuz
Loading

Fixes #1317

  • Rename an existing section of the general settings dialog to "Run options" so I don't have to add another section with a single setting in it
  • Add a general setting "Minimize to system tray on AutoRun", which defaults to true to maintain existing behaviour by default
  • Check that setting before attempting to minimize the app
image

@DocMoebiuz If you give me the German translation for that string I can add it to the string resources for the dialog

@neilenns neilenns requested a review from DocMoebiuz as a code owner October 12, 2023 12:53
@github-actions
Copy link

Build for this pull request:
MobiFlightConnector.zip

@neilenns
Copy link
Contributor Author

Just pushed a change to fix the tab order in the general settings as well.

@github-actions
Copy link

Build for this pull request:
MobiFlightConnector.zip

@DocMoebiuz
Copy link
Collaborator

Fixes #1317

  • Rename an existing section of the general settings dialog to "Run options" so I don't have to add another section with a single setting in it
  • Add a general setting "Minimize to system tray on AutoRun", which defaults to true to maintain existing behaviour by default
  • Check that setting before attempting to minimize the app
image @DocMoebiuz If you give me the German translation for that string I can add it to the string resources for the dialog

German translation: "Bei AutoRun in Task Leiste minimieren"

@neilenns
Copy link
Contributor Author

@DocMoebiuz Can I also get for "Run options"?

@DocMoebiuz
Copy link
Collaborator

DocMoebiuz commented Oct 17, 2023 •
edited
Loading

@DocMoebiuz Can I also get for "Run options"?

@neilenns

"Run" Optionen

@neilenns
Copy link
Contributor Author

Updated with the German strings

@github-actions
Copy link

Build for this pull request:
MobiFlightConnector.zip

@DocMoebiuz DocMoebiuz merged commit 5e185fb into MobiFlight:main Oct 17, 2023
1 check passed
@DocMoebiuz DocMoebiuz added the feature A new feature label Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DocMoebiuz DocMoebiuz Awaiting requested review from DocMoebiuz DocMoebiuz is a code owner

Assignees
No one assigned
Labels
feature A new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a setting to disable auto-minimize on auto-run
2 participants
@neilenns @DocMoebiuz