Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

math-expression-evaluator does allow omitting 0 from decimal number #16

Closed
bugwheels94 opened this issue Aug 23, 2016 · 5 comments
Closed

Comments

@bugwheels94
Copy link

After removing the line 38 it still is passing all the test, may you tell the reason for this comment

// CSS allow to omit 0 for 0.* values,
// but math-expression-evaluator does not

I want to know the test case for this it failed so that I can correct it. Thanks

@bugwheels94
Copy link
Author

Oh I forgot to tell that the test are passing because I designed it to omit leading 0s

@MoOx
Copy link
Owner

MoOx commented Aug 24, 2016

because I designed it to omit leading 0s

With version 1.2.9 it was not the case, I added this code to make tests pass. Did you make any change?

@bugwheels94
Copy link
Author

Yes I did. 1.2.10 was just changed for this purpose bugwheels94/math-expression-evaluator@d6a82d8

@MoOx
Copy link
Owner

MoOx commented Aug 24, 2016

Poke @ben-eb

@ben-eb
Copy link
Collaborator

ben-eb commented Aug 24, 2016

Yep, all of the current tests pass by changing this line. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants