[mocks] make location.onhashchange debounced async #1766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the mock
history.onhashchangebehave closer to the real thing.This patch only changes
test-utils/pushStateMock.jsand the corresponding test files. Since the mocks supportpushState, theonhashchangemode of the router is apparently never tested (or at least never in ways that differ whetheronhashchangeis synchronous or debounced, async).This is a prerequisite to fix #1734. Theoretically, the rest of the fix may be independent of #1592 / #1765 but if the tests must be modified in any way, I'd rather wait on at least #1592 to be merged, otherwise conflicts will arise.