Added description for includes #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added description
added description
Mistrick
requested changes
Jun 5, 2023
| * Gets the type of the specified box. | ||
| * | ||
| * @param box The index of the box. | ||
| * @param type The type of the box. |
There was a problem hiding this comment.
Это выходной параметр, надо об этом сказать.
| * | ||
| * @param box The index of the box. | ||
| * @param type The type of the box. | ||
| * @param len The length of the type of the box. |
There was a problem hiding this comment.
Максимально допустимая длина предыдущего параметра. Текущие описание об этом ничего не говорит.
| * TODO | ||
| */ | ||
| /** | ||
| * Called when an entity invalidly touches a box. |
There was a problem hiding this comment.
Надо указать, когда тач будет не валидным. Сейчас форвад вызывает, если entity, которая была в соприкосновении с коробкой, перестала быть валидной.
| * Called when an entity invalidly touches a box. | ||
| * | ||
| * @param box The index of the box. | ||
| * @param ent The entity that invalidly touched the box. |
There was a problem hiding this comment.
Надо понимать, что этот параметр передает невалидный индекс entity. Т.е. с ним нельзя выполнять никаких действий движка.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated by ChatGPT-3.5