Change grep command in README for arm64 to also work with Linux #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linux does not use arm64 for uname, so grep does not work, leading in a resulting confusing error. MacOS (Ventura): ``` Darwin foo 22.6.0 Darwin Kernel Version 22.6.0: Mon Feb 19 19:43:13 PST 2024; root:xnu-8796.141.3.704.6~1/RELEASE_ARM64_T6020 arm64 arm Darwin ``` Linux aarch64 (OrangePi, Ubuntu 22.04): ``` Linux foo 5.10.160-rockchip MisterTea#37 SMP Fri Apr 26 05:16:30 UTC 2024 aarch64 aarch64 aarch64 GNU/Linux ``` Linux aarch64 (AWS, Ubuntu 24.04): ``` Linux foo 6.8.0-1008-aws MisterTea#8-Ubuntu SMP Sat Apr 20 02:43:14 UTC 2024 aarch64 aarch64 aarch64 GNU/Linux ``` Tested with both system grep and grep 3.11 installed via Homebrew for MacOS: ``` grep (BSD grep, GNU compatible) 2.6.0-FreeBSD ``` Homebrew: ``` grep (GNU grep) 3.11 Packaged by Homebrew Copyright (C) 2023 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later <https://gnu.org/licenses/gpl.html>. This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Written by Mike Haertel and others; see <https://git.savannah.gnu.org/cgit/grep.git/tree/AUTHORS>. grep -P uses PCRE2 10.43 2024-02-16 ``` Consistency, yay.
|
Thanks! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #639 +/- ##
==========================================
- Coverage 70.77% 70.67% -0.10%
==========================================
Files 51 51
Lines 3206 3206
Branches 402 402
==========================================
- Hits 2269 2266 -3
- Misses 937 940 +3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linux does not use arm64 for uname, so grep does not work, leading in a resulting confusing error.
MacOS (Ventura):
Linux aarch64 (OrangePi, Ubuntu 22.04):
Linux aarch64 (AWS, Ubuntu 24.04):
Tested with both system grep and grep 3.11 installed via Homebrew for MacOS:
Homebrew:
Consistency, yay.