Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix readme regarding port forwarding #522

Merged
merged 1 commit into from
Jun 12, 2022
Merged

Conversation

cbyrohl
Copy link
Contributor

@cbyrohl cbyrohl commented Jun 11, 2022

Adjusting the docs regarding port forwarding as

user@machine:~$ et -t "2222:2222" remote

works, while original readme's instructions fail with


user@machine:~$ et -t="2222:2222" remote
Exception: Argument ‘-t=2222:2222’ starts with a - but has incorrect syntax

Tested with et version 6.2.1

@codecov-commenter
Copy link

Codecov Report

Merging #522 (f53dc86) into master (113fb23) will increase coverage by 0.21%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #522      +/-   ##
==========================================
+ Coverage   71.22%   71.44%   +0.21%     
==========================================
  Files          49       49              
  Lines        3058     3050       -8     
==========================================
+ Hits         2178     2179       +1     
+ Misses        880      871       -9     
Impacted Files Coverage Δ
src/base/PipeSocketHandler.cpp 73.07% <0.00%> (+0.70%) ⬆️
src/terminal/TerminalClient.cpp 42.12% <0.00%> (+0.90%) ⬆️
src/base/ServerClientConnection.cpp 96.42% <0.00%> (+3.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 113fb23...f53dc86. Read the comment docs.

@MisterTea
Copy link
Owner

Thanks!

@MisterTea MisterTea merged commit 6f89484 into MisterTea:master Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants