Failure to build with Mac Sonoma 14.7

[mattgodbolt]

When trying to install with brew on Sonoma 14.7:

==> Installing et from mistertea/et
==> cmake . -DDISABLE_VCPKG:BOOL=ON -DPYTHON_EXECUTABLE=/usr/bin/python3
==> make install
Last 15 lines from /Users/mgodbolt/Library/Logs/Homebrew/et/02.make:
/tmp/et-20241022-97876-5tiujl/EternalTerminal-et-v6.2.9/external_imported/sentry-native/external/crashpad/minidump/minidump_misc_info_writer.cc:194:47: error: use of undeclared identifier '__MAC_OS_X_VERSION_MAX_ALLOWED'
  194 |       AvailabilityVersionToMacOSVersionNumber(__MAC_OS_X_VERSION_MAX_ALLOWED));
      |                                               ^
1 error generated.

I've tried reinstalling the latest developer tools (at least I think I have) as I saw other reports that looked a little similar, but this doesn't seem to be missing header files. Any help welcomed. Thank you!

[MisterTea]

Can you try this solution and let us know if you can compile with it: https://stackoverflow.com/a/44340246

…

On Tue, Oct 22, 2024 at 9:30 AM Matt Godbolt ***@***.***> wrote: When trying to install with brew on Sonoma 14.7: ==> Installing et from mistertea/et ==> cmake . -DDISABLE_VCPKG:BOOL=ON -DPYTHON_EXECUTABLE=/usr/bin/python3 ==> make install Last 15 lines from /Users/mgodbolt/Library/Logs/Homebrew/et/02.make: /tmp/et-20241022-97876-5tiujl/EternalTerminal-et-v6.2.9/external_imported/sentry-native/external/crashpad/minidump/minidump_misc_info_writer.cc:194:47: error: use of undeclared identifier '__MAC_OS_X_VERSION_MAX_ALLOWED' 194 | AvailabilityVersionToMacOSVersionNumber(__MAC_OS_X_VERSION_MAX_ALLOWED)); | ^ 1 error generated. I've tried reinstalling the latest developer tools (at least I think I have) as I saw other reports that looked a little similar, but this doesn't seem to be missing header files. Any help welcomed. Thank you! — Reply to this email directly, view it on GitHub <#664>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACK5PYMWCSQVYACL536XR3Z4ZOR7AVCNFSM6AAAAABQMU4VXWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGYYDKNRTGM4DEMY> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[mattgodbolt]

Hi: I'll give it a go but presumably that means I can't use brew and I'll need to check out this repo and try building directly from it. Will give that a go (unfortunately I'm a total mac noob, it's a dumb terminal to get me to Linux :D )

[mattgodbolt]

Thanks for the instructions on building: I followed and they failed during the cmake .. as it builds the 3rd party deps:

Call Stack (most recent call first):
  /Users/mgodbolt/dev/oss/EternalTerminal/build/vcpkg_installed/arm64-osx/share/vcpkg-cmake/vcpkg_cmake_build.cmake:74 (vcpkg_execute_build_process)
  /Users/mgodbolt/dev/oss/EternalTerminal/build/vcpkg_installed/arm64-osx/share/vcpkg-cmake/vcpkg_cmake_install.cmake:16 (vcpkg_cmake_build)
  ports/sentry-native/portfile.cmake:56 (vcpkg_cmake_install)
  scripts/ports.cmake:175 (include)


error: building sentry-native:arm64-osx failed with: BUILD_FAILED
Elapsed time to handle sentry-native:arm64-osx: 5.5 s
Please ensure you're using the latest port files with `git pull` and `vcpkg update`.
Then check for known issues at:
  https://github.com/microsoft/vcpkg/issues?q=is%3Aissue+is%3Aopen+in%3Atitle+sentry-native
You can submit a new issue at:
  https://github.com/microsoft/vcpkg/issues/new?title=[sentry-native]+Build+error+on+arm64-osx&body=Copy+issue+body+from+%2FUsers%2Fmgodbolt%2Fdev%2Foss%2FEternalTerminal%2Fbuild%2Fvcpkg_installed%2Fvcpkg%2Fissue_body.md

-- Running vcpkg install - failed
CMake Error at external/vcpkg/scripts/buildsystems/vcpkg.cmake:899 (message):
  vcpkg install failed.  See logs for more information:
  /Users/mgodbolt/dev/oss/EternalTerminal/build/vcpkg-manifest-install.log
Call Stack (most recent call first):
  /opt/homebrew/Cellar/cmake/3.30.5/share/cmake/Modules/CMakeDetermineSystem.cmake:146 (include)
  CMakeLists.txt:81 (project)

as with the above it seems like it's a problem in sentry-native's build, so ... I'll poke about in there and see what I can change...

[mattgodbolt]

Actually there's nowhere for me to put this, and it seems like it's a vcpkg issue? I can't see how to edit a CMake cache variable that'll be picked up by a build that vcpkg is seemingly doing behind my back?

[mattgodbolt]

Created microsoft/vcpkg#41756 - thanks again for the help so far.

[MisterTea]

Makes sense, best of luck!

…

On Thu, Oct 24, 2024 at 9:32 AM Matt Godbolt ***@***.***> wrote: Created microsoft/vcpkg#41756 <microsoft/vcpkg#41756> - thanks again for the help so far. — Reply to this email directly, view it on GitHub <#664 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACK5P7LQONEYYFN5SBPPUTZ5EAHTAVCNFSM6AAAAABQMU4VXWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZVGQ3DKOBTHE> . You are receiving this because you commented.Message ID: ***@***.***>