Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurable log paths and address log path permission concerns #555

Closed
jshort opened this issue Dec 16, 2022 · 0 comments
Closed

Add configurable log paths and address log path permission concerns #555

jshort opened this issue Dec 16, 2022 · 0 comments

Comments

@jshort
Copy link
Collaborator

jshort commented Dec 16, 2022

This is a feature request to allow an ini-config based and/or cxxopts way to change the location of the log files from /tmp to a directory of your choice:

  • ideally the logfiles should go into a dedicated directory e.g. in
    /var/log/et for the server side.
  • for the client side a set of logfiles can be kept in the home
    directory, but old logs should be deleted after some time.
    Alternatively client logs can be placed into /run/user//et-logs
    or a similar location.
  • when using shared world-writable directories like /tmp then at least
    O_NOFOLLOW|O_EXCL|O_CREAT should also be added to open() flags. If
    open fails then it should be retried with alternative filenames until
    it succeeds.
  • the file mode mask should be set in a way that the resulting files
    only have 0600 permissions i.e. read and write permission for the
    owner to avoid leaking information to other users on the system.
jshort added a commit to jshort/EternalTerminal that referenced this issue Dec 20, 2022
jshort added a commit to jshort/EternalTerminal that referenced this issue Dec 20, 2022
jshort added a commit to jshort/EternalTerminal that referenced this issue Dec 20, 2022
jshort added a commit to jshort/EternalTerminal that referenced this issue Dec 20, 2022
jshort added a commit to jshort/EternalTerminal that referenced this issue Dec 20, 2022
jshort added a commit to jshort/EternalTerminal that referenced this issue Dec 20, 2022
jshort added a commit to jshort/EternalTerminal that referenced this issue Dec 21, 2022
jshort added a commit to jshort/EternalTerminal that referenced this issue Dec 21, 2022
jshort added a commit to jshort/EternalTerminal that referenced this issue Dec 21, 2022
jshort added a commit to jshort/EternalTerminal that referenced this issue Dec 21, 2022
jshort added a commit to jshort/EternalTerminal that referenced this issue Dec 21, 2022
jshort added a commit to jshort/EternalTerminal that referenced this issue Dec 21, 2022
jshort added a commit to jshort/EternalTerminal that referenced this issue Dec 22, 2022
jshort added a commit to jshort/EternalTerminal that referenced this issue Jan 13, 2023
jshort added a commit to jshort/EternalTerminal that referenced this issue Jan 13, 2023
@jshort jshort closed this as completed in 92c4c6a Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant