Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ギャラリー機能にブックビューア機能を追加 #782

Closed
wants to merge 3 commits into from

Conversation

tar-bin
Copy link

@tar-bin tar-bin commented Oct 31, 2024

What

Misskeyのギャラリー機能に本形式のビューアを追加

Why

#781 の対応

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@tar-bin tar-bin changed the title ギャラリー機能にブックビューア機能を追加 feat: ギャラリー機能にブックビューア機能を追加 Oct 31, 2024
@tar-bin tar-bin marked this pull request as draft October 31, 2024 05:48
@tar-bin tar-bin marked this pull request as ready for review October 31, 2024 06:42
Copy link

sonarcloud bot commented Oct 31, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link
Member

@u1-liquid u1-liquid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • PNPM Lockfileが壊れていますので修正が必要です。
  • SonarCloudで検出されたIssueの解消が必要です。
  • turn.js 4th ReleaseのライセンスはOSSではないとのことなので、このリポジトリで取り扱うには問題があります。(3rd ReleaseまではBSDライセンスですが、4からはOSSとしての公開を中止しています)
    3rd Releaseのコードベースを使用するか、別のライブラリもしくは内製の実装に置き換える必要がありそうです。
    3rd Releaseを使用する場合、当リポジトリのライセンスのAGPLとは違うライセンス(BSD ライセンス)で公開されているので、原則的にはこのリポジトリで再配布することは避けるべきです。ソースコードの変更が必要などの理由でこのリポジトリ上に置く必要がある場合は、以下のようにSPDXヘッダーを追記してください。
    /*
    * SPDX-FileCopyrightText: Isaac Z. Schlueter and Contributors of https://github.com/isaacs/ttlcache
    * SPDX-License-Identifier: ISC
    *
    * This file is derived from the project that has licensed under the ISC license.
    * This file SHOULD NOT be considered as a part of this project that has licensed under AGPL-3.0-only
    * Adapted from https://github.com/isaacs/ttlcache/blob/b6002f971e122e3b35e23d00ac6a8365d505c14d/examples/rate-limiter-window.ts
    */

@tar-bin
Copy link
Author

tar-bin commented Nov 1, 2024

レビューありがとうございます。ちょっとturn.jsのソースを含むコミットを含むのは避けたほうがいいので一旦PRを出し直します。

@tar-bin tar-bin closed this Nov 1, 2024
@tar-bin tar-bin deleted the addBookViewerToGallary branch November 1, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants