Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend/notes/mentions): @mentionされていないノートがあなた宛てに載ってしまう問題を修正 #388

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

u1-liquid
Copy link
Member

What

@mentionされていないノートがあなた宛てに載ってしまう問題を修正

Why

通常のspecified投稿の場合、visibleUserIdsはmentionsに含まれるので、このクエリーでvisibleUserIdsを参照する必要はない

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

通常のspecified投稿の場合、visibleUserIdsはmentionsに含まれるので、このクエリーでvisibleUserIdsを参照する必要はない
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
3.8% Duplication on New Code

See analysis details on SonarCloud

@u1-liquid u1-liquid merged commit 1e093f3 into MisskeyIO:io Jan 26, 2024
16 checks passed
@u1-liquid u1-liquid deleted the fix-mentions-visibleUserIds branch January 26, 2024 16:02
noellabo pushed a commit to fedibird/misskey that referenced this pull request Dec 17, 2024
…skeyIO#388)

通常のspecified投稿の場合、visibleUserIdsはmentionsに含まれるので、このクエリーでvisibleUserIdsを参照する必要はない
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant