enhance: シャットダウン時、DB接続が切れたら確実に終了させる #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
appからmodule destroyedを実装してるサービスを持ってきてコールバック登録させてapp.closeを呼ぶといい感じに終了させれるらしいので修正します |
app.close呼ぶだけでは終了されないので今の実装のほうが確実かも |
|
終了させる部分はいったん抜いてワーカーのリプレイスの部分だけにする？ |
riku6460
reviewed
Aug 25, 2023
|
こんな感じで終わる |
|
Kudos, SonarCloud Quality Gate passed!
|
u1-liquid
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
まだプライマリープロセスが終わらないことがある
DB接続が切れたら何もできるはずがないので、確実に終了するようにイベントを呼ぶ
Why
nestjsがおかしいかも
裏は全く取れてないけど個人的にはQueueProcessorServiceが怪しい
（Masterでは使われないのでそもそも呼び出されないが、handlerはあるのでこれが終わるのを待ってるとか？）
Additional info (optional)
タスクマネージャからプライマリープロセスを終了させようとすると反応しないのが直った
プライマリープロセスがシャットダウン中のみワーカープロセスが再起動しないようにした
Checklist