Don't set network_ids when using basic networking

[hrak]

In version 1.4.0, when using basic networking @networks is set to CloudstackResource.new(nil, nil, 'network') on this line, so @networks is never empty.

In this case @networks.map(&:id).compact.join(",") as used on this line results in an empty string.

This causes the deployVirtualMachine API request to include "networkids" => "" which makes CloudStack throw the error Can't specify network Ids in Basic zone.

[coveralls]

Changes Unknown when pulling 6a822b1 on hrak:fix/no_network_ids_in_basic_zone into ** on MissionCriticalCloud:master**.

[miguelaferreira]

@bheuvel are you able to test this?

[bheuvel]

@miguelaferreira possibly, mostly need to find the time to create an environment with basic networking. Don't have one running atm...

[miguelaferreira]

ack

[bheuvel]

@hrak sorry for the long delay, but I don't have (time for creating) a basic zone.

Had a quick look at the cloudstack code, and it indeed only checks null value, not (even) empty strings.

Just tested it on Advanced zone and it has no negative side-effects, so will merge it.

[bheuvel]

Running RSpec tests in folder : vmlifecycle
Using Vagrant file            : Vagrantfile.advanced_networking

VM Life Cycle
  starts Linux and Windows VM
  destroys Linux and Windows VM

Finished in 2 minutes 19.8 seconds (files took 0.09403 seconds to load)
2 examples, 0 failures

Running RSpec tests in folder : networking
Using Vagrant file            : Vagrantfile.advanced_networking

Networking features
  creates firewall and portwarding rules for both Virtual Router and VPC

Finished in 3 minutes 32.9 seconds (files took 0.09126 seconds to load)
1 example, 0 failures

Running RSpec tests in folder : rsync
Using Vagrant file            : Vagrantfile.advanced_networking

VM RSync
  does rsync to the VM

Finished in 59.64 seconds (files took 0.09303 seconds to load)
1 example, 0 failures