Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow trusted_networks as both string or array #146

Merged
merged 2 commits into from
Mar 24, 2016

Conversation

bheuvel
Copy link
Contributor

@bheuvel bheuvel commented Mar 23, 2016

Has advantages of #113 while also keeping configfiles (Vagrant, Test-Kitchen) backward compatible.

@bheuvel bheuvel force-pushed the tech/trust_nw_as_string branch from 7b0e580 to 5893e87 Compare March 24, 2016 09:29
RSync can fail on Windows, and stops(/hangs) testing.
@bheuvel
Copy link
Contributor Author

bheuvel commented Mar 24, 2016

Test result from Windows host; all green, except rsync test (as expected)

Running RSpec tests in folder : vmlifecycle
Using Vagrant file            : Vagrantfile.advanced_networking

VM Life Cycle
  starts Linux and Windows VM
  destroys Linux and Windows VM

Finished in 2 minutes 59.2 seconds (files took 0.125 seconds to load)
2 examples, 0 failures

Running RSpec tests in folder : networking
Using Vagrant file            : Vagrantfile.advanced_networking

Networking features
  creates firewall and portwarding rules

Finished in 3 minutes 6.3 seconds (files took 0.121 seconds to load)
1 example, 0 failures

Running RSpec tests in folder : rsync
Using Vagrant file            : Vagrantfile.advanced_networking

VM RSync
There was an error when attempting to rsync a synced folder.
Please inspect the error message below for more info.

@miguelaferreira
Copy link
Contributor

I get the same results:

Running RSpec tests in folder : vmlifecycle
Using Vagrant file            : Vagrantfile.advanced_networking

VM Life Cycle
  starts Linux and Windows VM
  destroys Linux and Windows VM

Finished in 3 minutes 56.5 seconds (files took 0.14185 seconds to load)
2 examples, 0 failures

Running RSpec tests in folder : networking
Using Vagrant file            : Vagrantfile.advanced_networking

Networking features
  creates firewall and portwarding rules

Finished in 4 minutes 22.7 seconds (files took 0.10225 seconds to load)
1 example, 0 failures

Running RSpec tests in folder : rsync
Using Vagrant file            : Vagrantfile.advanced_networking

VM RSync
Connection to 31.22.84.56 closed.
  does rsync to the VM

Finished in 1 minute 4.78 seconds (files took 0.08991 seconds to load)
1 example, 0 failures

👍

@miguelaferreira miguelaferreira merged commit 62eb540 into master Mar 24, 2016
@miguelaferreira miguelaferreira deleted the tech/trust_nw_as_string branch March 24, 2016 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants