forked from vercel/vercel
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Default ruby to only currently supported version (3.2.0) (vercel#11104)
We're currently using the directory name at `./vendor/bundle/ruby/`[0] to determine ruby version. This directory is created as part of running `bundle install` during the build process. However, when multiple ruby versions are available, you can end up with multiple directories and the 0th entry at `./vendor/bundle/ruby/` isn't guaranteed to be the Ruby version specified in the project. Other companies in this space seem to do some order of - check for value in `.ruby-version` file - check for value passed into `ruby` directive in the Gemfile - check the value in the `*.gemspec` file if the Gemfile has a `gemspec` directive. We'll do that work in a future PR but for _now_ our only supported Ruby version is Ruby 3.2.x [as of 2023-11-22](https://vercel.com/changelog/upgrading-ruby-v2-7-to-v3-2). So this can be hard-coded for the moment. Skipping ruby tests now since these target _current_ prod where Ruby 3.2.x is not in `PATH` until we redeploy after this gets deployed.
- Loading branch information
Showing
4 changed files
with
16 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@vercel/static-build": minor | ||
--- | ||
|
||
Default ruby to only currently supported version (3.2.0) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters