Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add S3 upload arguments #2068

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

StevePorter92
Copy link

@StevePorter92 StevePorter92 commented Mar 26, 2020

Description

This allows the use of upload arguments to be passed through to the S3
client.

This will enable server-side encryption on S3 buckets.

https://boto3.amazonaws.com/v1/documentation/api/latest/reference/customizations/s3.html#boto3.s3.transfer.S3Transfer.ALLOWED_UPLOAD_ARGS

For #1792

GitHub Issues

#1792

This allows the use of upload arguments to be passed through to the S3
client.

This will enable server side encryption on S3 buckets.

https://boto3.amazonaws.com/v1/documentation/api/latest/reference/customizations/s3.html#boto3.s3.transfer.S3Transfer.ALLOWED_UPLOAD_ARGS

For Miserlou#1792
@coveralls
Copy link

coveralls commented Mar 26, 2020

Coverage Status

Coverage increased (+0.04%) to 73.005% when pulling 664fe78 on StevePorter92:s3-upload-args into 80a6881 on Miserlou:master.

@flingure
Copy link

flingure commented Feb 1, 2021

That would be a much appreciated feature! If it could pass the CI...

@StevePorter92
Copy link
Author

Fixed the CI build

/cc @flingure

@flingure
Copy link

flingure commented Feb 2, 2021

Many thanks StevePorter92!
Hope it gets merged pretty soon!

@StevePorter92
Copy link
Author

Is there any chance this could be available for the next release @jneves?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants