-
-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: spatial hashing for InterestManagementBase #3380
Draft
imerr
wants to merge
12
commits into
master
Choose a base branch
from
feat/ll_spatial_im
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oh, the interest management test setup does not play well with this (from memory):
So that would need improving too |
Ideally we'd just do a 1:1 non-breaking replacement for the normal spatial hashing here so users don't have to care, that should be doable? |
MrGadget1024
added
the
work in progress
Need more time to decide. Nothing to do here for now.
label
Feb 15, 2023
imerr
force-pushed
the
feat/ll_spatial_im
branch
from
February 16, 2023 11:25
c1e04e6
to
561ca26
Compare
imerr
changed the title
perf: spatial hashing for low level interest management
perf: spatial hashing for InterestManagementBase
Feb 16, 2023
imerr
force-pushed
the
feat/ll_spatial_im
branch
from
February 16, 2023 11:56
561ca26
to
01604a9
Compare
imerr
force-pushed
the
feat/ll_spatial_im
branch
from
October 15, 2023 16:29
01604a9
to
3c5e363
Compare
imerr
force-pushed
the
feat/ll_spatial_im
branch
from
January 29, 2024 15:37
3c5e363
to
7a356e7
Compare
imerr
force-pushed
the
feat/ll_spatial_im
branch
from
January 29, 2024 17:54
7a356e7
to
338c063
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is very much a work in progress and NEEDS changing before it is ready to merge (no runtime visibility changes and probably needs code cleaning up/commenting)
In my past testing, it's 4x faster for me
In @ninjakickja's recent testing ("simulation") it's 2.5x faster than the current one
Depends on/see #3379