[BOP-1204] Password encryption on the server side #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
There are two changes in this PR:
password
field.hash
) should not be a base64 encoded plain text, rather than bcrypt encrypt stringRemoved
password
envelopeRemoved the
password
envelope from create user and list user endpoints.Here are the new request/responses:
List User
Response
Create User
Request
Base64 Encoded Plain Text Password
The bigger change is the accepting a plain text password (base64 encoded), instead of bcrypt encrypted string.
Create User Request
Note: The
userId
field can also be ommited as this is also generated on the server sideUpdate User Password Request
hash
andnewHash
field for passwordThe name of the field that contains the password is still
hash
and newHash. This cannot be changed as we are currently generating code from the dex's proto buf.Also, the password in
hash
andnewHash
field must be base64 encoded. This also cannot be modified at this moment