Support reopen tap FD if something wrong to VM #864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keyingliu
force-pushed
the
retrieve
branch
3 times, most recently
from
2be8bcc to
5382fc1
Compare
jellonek
suggested changes
Feb 13, 2019
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1.
Reviewable status: 1 change requests, 0 of 1 approvals obtained (waiting on @keyingliu)
pkg/tapmanager/tapfdsource.go, line 355 at r1 (raw file):
}() if podNet == nil { return nil, fmt.Errorf("bad key (%s) to retrieve FDs", key)
Please use %q instead of (%s).
|
Updated |
jellonek
approved these changes
Feb 13, 2019
There was a problem hiding this comment.
Can you add test cases to cover these changes?
If not - we have to add a followup issue for them.
Reviewed 1 of 1 files at r2.
Reviewable status:complete! 1 of 1 approvals obtained
|
Sure, will have another commit for unit test |
ivan4th
approved these changes
Feb 14, 2019
There was a problem hiding this comment.
Reviewed 2 of 4 files at r1, 1 of 1 files at r2, 1 of 1 files at r3.
Reviewable status:
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #833
This change is