perf(Visibility): adding SpatialHash components #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SonarCloud Quality Gate failed. |
James-Frowen
force-pushed
the
spatial-hash
branch
from
0e571ba to
3d46d9f
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
James-Frowen
commented
Apr 30, 2022
Comment on lines
+219
to
+223
| float fx = position.x - Offset.x; | ||
| float fy = position.y - Offset.y; | ||
|
|
||
| x = Mathf.RoundToInt(fx / GridSize.x); | ||
| y = Mathf.RoundToInt(fy / GridSize.y); |
There was a problem hiding this comment.
Currently bugged near edge, might need extra offset of GridSize/2 or something.
Unit tests would be good for this function.
James-Frowen
commented
Apr 30, 2022
| /// <returns>True if the player can see this object.</returns> | ||
| public override bool OnCheckObserver(INetworkPlayer player) | ||
| { | ||
| ThrowIfNoSystem(); |
There was a problem hiding this comment.
should return and wait for system instead of throw. System can rebuild existing NI when it starts.
This is to better deal with spawning objects inside server.Started, the system might not be first in even list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.