feat: init the module, define models and views #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janikvonrotz
requested changes
Oct 7, 2024
account_oss_report/README.rst
Outdated
| :alt: License: GPL-3 | ||
|
|
||
| ================== | ||
| Account Oss Report |
account_oss_report/README.rst
Outdated
| Account Oss Report | ||
| ================== | ||
|
|
||
| Module summary. |
account_oss_report/__manifest__.py
Outdated
| "category": "Accounting", | ||
| "version": "16.0.1.0.0", | ||
| "license": "AGPL-3", | ||
| "depends": ["account", "l10n_eu_oss"], |
There was a problem hiding this comment.
Please do not depend on l10n_eu_oss
| @@ -0,0 +1,75 @@ | |||
| from odoo import api, fields, models | |||
|
|
|||
| class AccountOssReport(models.Model): | |||
| # tax_type = fields.Selection() | ||
|
|
||
| @api.model | ||
| def _get_account_move_data(self, data=None, start_date=False, end_date=False): |
| data = [] | ||
|
|
||
| # Fetch the tag for "OSS" to use in the domain | ||
| oss_tag = self.env['account.account.tag'].search([('name', '=', 'OSS')], limit=1) |
There was a problem hiding this comment.
I don't like this. The tag should be define as an XML ID.
| # Fetch move lines that match the criteria | ||
| move_lines = self.env['account.move.line'].search(domain) | ||
|
|
||
| for line in move_lines: |
There was a problem hiding this comment.
The data should be grouped by country code!
And you have to distinct between tax included and excluded.
| <field name="view_mode">tree</field> | ||
| </record> | ||
|
|
||
| <!-- <menuitem id="menu_account_oss_report" --> |
There was a problem hiding this comment.
Please remove comment code.
There was a problem hiding this comment.
I think we can get rid of the wizard.
The calculation should be pretty fast, so not wizard might be required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.