Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Faster make site and make lint. #41

Closed
MinoruSekine opened this issue Jul 18, 2024 · 1 comment · Fixed by #42
Closed

Faster make site and make lint. #41

MinoruSekine opened this issue Jul 18, 2024 · 1 comment · Fixed by #42
Assignees
@MinoruSekine
Labels
bug Something isn't working

Comments

@MinoruSekine
Copy link
Owner

  • Both make site and make lint are now including npm install in their steps
  • In most cases, local developers have set up tools in their environments
  • But Makefile calls npm install if he runs target which needs node modules
  • So..
    • Omit npm install from Makefile
    • Run npm install in GitHub Actions workflows which need node modules
@MinoruSekine MinoruSekine added the bug Something isn't working label Jul 18, 2024
@MinoruSekine MinoruSekine self-assigned this Jul 18, 2024
@MinoruSekine
Copy link
Owner Author

MinoruSekine/nol_hero_bond#41

MinoruSekine added a commit that referenced this issue Jul 18, 2024
@MinoruSekine
fix: Too small font on phone by responsive design. (#41)
77b248f
MinoruSekine added a commit that referenced this issue Jul 21, 2024
@MinoruSekine
fix: Slow make lint and make site. (#41)
df238b7
@MinoruSekine MinoruSekine linked a pull request Jul 21, 2024 that will close this issue
fix: Slow make lint and make site. (#41) #42
Merged
MinoruSekine added a commit that referenced this issue Jul 22, 2024
@MinoruSekine
Merge pull request #42 from MinoruSekine/fix/41/slow_make_lint_site
7789a2c 
fix: Slow make lint and make site. (#41)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MinoruSekine MinoruSekine

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Slow make lint and make site. (#41) MinoruSekine/nol_tsukumo
1 participant
@MinoruSekine