Update some code handling strings where performance issues occur #688
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves a little performance issue. Here,
Double#parseDouble
is used to validate whether the input is double. It can be problematic as it throws exceptions when the input is invalid while the input is invalid most of the time. It is known that creation of exceptions are expensive due to the creations of stack traces. This pull request changes it to regex matching, though I doubt there would be an entry of number with localization enabled.1~5% performance improvement is already significant when CPU time can be reduced. This kind of use cases (using methods with exceptions) will be carefully assessed when it can affect performance, in the code optimization task in the near future.