-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Game Profile Metadata Configuration file for mutable global configurations #609
Draft
BenCheung0422
wants to merge
26
commits into
MinicraftPlus:main
Choose a base branch
from
BenCheung0422:devbuild
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`String#split` trims the trailing empty string so there is no empty string in the resultant list.
Revision tested: 585fef3 Only initial world is tested
# Conflicts: # .github/workflows/autobuild.yml # build.gradle # src/client/java/minicraft/core/Game.java
# Conflicts: # src/client/java/minicraft/saveload/Load.java # src/client/resources/assets/localization/en-us.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on #618
This will be done for 2.3 as this needs rewritten code from "class optimization" pull request
There are 2 places for the places of game version, in
build.gradle
andGame.java
. This can lead to a chance of missing change when updating the game version. This adds a global profile config file for the whole projectgame_profile.conf
. The in-game metadata file is generated by Gradle build directly. Eventually, only 1 place is needed to be updated. Also, furthermore profile meta data can be added into the config file in the future, in case needed.TODO:
Version
to world versions in Save/Loadgame_profile.conf
stable
check directly ingame_profile.conf
isDev
is no longer needed forVersion
use_editor
ingame_profile.conf
version.json
in jar on buildid
,world_version
,stable
,use_editor
,build_time
,series_id
game_profile.conf
in code on initialization.(Edited on 2024/01/11)
Old summary