Add recipe advancement adder to Recipes.java #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenCheung0422
added a commit
to BenCheung0422/minicraft-plus-revived
that referenced
this pull request
Oct 10, 2023
This will be redone later.
# Conflicts: # src/client/java/minicraft/item/Recipes.java # src/client/resources/resources/recipes.json
|
We are not renaming any items. |
|
This just renames the advancement keys. Stone is called stone, so I renamed the stone/rock level tools to "stone" instead of "rock", but only the code side. |
# Conflicts: # src/client/resources/resources/recipes.json
|
I won’t merge this until you change stone back to rock. It’s inconsistent and you shouldn’t change pre-existing names |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides an ability to generate
recipes.jsonautomatically with minor manual conflict fixing.This is directly copied from #445 because this occupies a high portion of changes within that pull request. This is regenerated again once either this or that pull request has been merged.
Recipe advancements removed (by keys):
Recipe advancements added (by keys):