Add hardware acceleration setting #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makkkkus
requested changes
Jul 2, 2023
|
Is it because it applies only on startup? |
|
Yeah, you could make it possible to be disabled by a launch argument. |
|
For convenience, it could be a setting that require a restart with modified value. |
|
No, using a launch argument would be more convenient. Both in code and use. |
|
Then, a launching argument modifying setting value. |
Hardware acceleration setting
|
Don't use the Settings class. That will just be confusing. |
|
The entire setting is removed from settings and preferences. It can now only be disabled by using a flag. |
|
You haven't fixed this yet. You need to revert the changes related to saving and remove a reference to the setting in OptionsMainMenuDisplay. |
Remove changes in loading and settings
|
Ok. |
ChristofferHolmesland
approved these changes
Jul 8, 2023
Makkkkus
approved these changes
Jul 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, hardware acceleration is not enabled. With help of #523, this could further reduce around 10%-15% CPU usage (with using GPU) when hardware acceleration is enabled.