Arrow hit limit

[afyber]

Adds a limit to the number of entities an arrow can hit before disappearing. Also reduces the damage for hits after the first.

[chrisj42]

So I think you'll find, if you test it, that this does not work as intended. The tick method is not called every time a separate mob is hit or something, it is called every frame, and an arrow will almost certainly be in contact with a mob for multiple frames at a time. This will increment mobsHit much faster than the number of mobs the arrow actually damages, or more precisely, the number of times the arrow hurts a mob.

The reason mobs are not damaged every tick is because they have an internal hurt cooldown.
What you want to do, then, is make a little refactor of the Mob hurt methods and doHurt method to return whether the mob was actually hurt or not. Then you can use this value to determine if mobsHit should be incremented or not. Also I think 2 mobs is too low, try 3 or 4.

[afyber]

like that?

[chrisj42]

Did you test it? think about what happens on a server. If you return false from doHurt for all remote players, then the arrow will never actually go away if it just hits players. But if you return true, then it will damage every frame.
So you see, there's actually a bigger problem here. Clients should not be dealing with damage to themselves, because then it messes up the server, and besides, it also opens up the ability to cheat.
And then, if you look at arrows, you see that they are updated on both the client and server, and that doesn't make total sense either. After all, then the client would track all arrow hits, and would remove the arrow, but the server would not remove it, and would continue until it hit 4 non-player mobs, resulting in apparent "ghost damage" in the client side.
Ideally, they would all be updated on the server, and the only things updated on the client are those that the server doesn't track, i.e. the particle subclasses. However, the player is updated partially on the client to mitigate lag.

So essentially, I can't accept this until you have a way of checking if the player actually got hurt on the server, so the ghost damage doesn't happen.