Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added multiple aspect ratios #301

Merged
merged 8 commits into from
Apr 21, 2022
Merged

Conversation

lino-levan
Copy link
Contributor

Is the start of dealing with #277. We probably need to rethink some of the menus but this works good enough as a start for now.

The default of 4x3 makes sense until we adjust menus for both 4x3 and 16x9.

The "Native" screen resolution option adjusts the screen resolution to that of the main monitor. On a Mac, it'd be 16x10. On most monitors, it'd be 16x9.

@Makkkkus
Copy link
Member

Makkkkus commented Apr 9, 2022

This is aspect ratio, not screen resolution.

@lino-levan
Copy link
Contributor Author

this is a great point, let me fix this

@lino-levan lino-levan changed the title Added multiple screen resolutions Added multiple aspect ratios Apr 9, 2022
@lino-levan
Copy link
Contributor Author

@Makkkkus does this look good?

Copy link
Member

@Makkkkus Makkkkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, but I don't think this is safe enough yet.

This might also break checking for entities on screen, and other quirks like that.

src/main/java/minicraft/core/Renderer.java Outdated Show resolved Hide resolved
src/main/java/minicraft/core/Renderer.java Outdated Show resolved Hide resolved
src/main/java/minicraft/core/Renderer.java Show resolved Hide resolved
src/main/java/minicraft/core/Renderer.java Show resolved Hide resolved
src/main/java/minicraft/core/io/Settings.java Outdated Show resolved Hide resolved
src/main/java/minicraft/screen/OptionsMainMenuDisplay.java Outdated Show resolved Hide resolved
@lino-levan
Copy link
Contributor Author

@Makkkkus does this look good?

@Makkkkus
Copy link
Member

Very good changes!

@lino-levan
Copy link
Contributor Author

Any other questions?

@Makkkkus
Copy link
Member

No

Copy link
Member

@Makkkkus Makkkkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good

src/main/java/minicraft/saveload/Load.java Outdated Show resolved Hide resolved
@Makkkkus Makkkkus merged commit 41e207f into MinicraftPlus:master Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants