Autoload sotrage adapters #555
Conversation
This file contains Rack::MiniProfiler, not Rack::MiniProfiler::Profiler.
- Make module files require their nested contents - Move library requires to the files that use them - Remove require for timeout because it isn't used - Remove require for thread because it is required by default This patch also allows for easier transition to autoloading should we choose to use it later.
Autoloads storage adapters because it is unnecessary to load storage adapters you won't use. Autoload lets us defer loading the file until it is referenced, so that we can require storage dependencies normally and expect them to load when called.
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #555 +/- ##
==========================================
+ Coverage 87.39% 87.42% +0.02%
==========================================
Files 18 20 +2
Lines 1269 1272 +3
==========================================
+ Hits 1109 1112 +3
Misses 160 160
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
The code changes Looks good to me. We just need to sync the autoload_storage_adapaters with the latest master and resolve the conflict. After @gmcgibbon is done with the mentioned action items, we can merge this code @nateberkopec . |
Autoloads storage adapters because it is unnecessary to load storage
adapters you won't use. Autoload lets us defer loading the file until it
is referenced, so that we can require storage dependencies normally and
expect them to load when called.
Depends on #551. I can't make a PR to this repo if my merge target is on my fork, so this will have to do for now.