Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instructions on actually rendering the mini profiler #555

Merged
merged 3 commits into from
May 8, 2021
Merged

Instructions on actually rendering the mini profiler #555

merged 3 commits into from
May 8, 2021

Conversation

Bouke
Copy link
Contributor

@Bouke Bouke commented Apr 15, 2021

I found the installation instructions confusing, and this issue provided some insights. I think it would be valuable to make these instructions part of the documentation.

NickCraver
NickCraver approved these changes May 8, 2021
View reviewed changes
Copy link
Member

@NickCraver NickCraver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good - thank you! The Web.config bit may not be needed, so I suggest we tweak that to reduce confusion then good to go :)

docs/AspDotNet.md Outdated Show resolved Hide resolved
@NickCraver NickCraver merged commit a8e89dd into MiniProfiler:main May 8, 2021
@Bouke Bouke deleted the patch-1 branch May 18, 2021 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickCraver NickCraver NickCraver approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bouke @NickCraver