Library Changes: Removing jQuery #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
November 30, 2019 14:28
This removes the jQuery bundling and dependency, taking the raw size from 133KB down to 48.3KB. Upsides: - Smaller payload - Fewer dependencies Downsides: - More maintenance/direct code in vailla JS/TS - No IE <= 11 Support (I'll try this next without fetch and see what the diff is) This also upgrades the TypeScript compiler and minifier which wasn't handling ES6 well. But this is a work-in-progress. Committing here because this is a stable and working ES6 version.
Open
xPaw
reviewed
Nov 30, 2019
xPaw
reviewed
Nov 30, 2019
ArtOfCode-
reviewed
Dec 1, 2019
NickCraver
commented
Dec 14, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the jQuery bundling and dependency, taking the raw size from 133KB down to 48.3KB.
Upsides:
Downsides:
This also upgrades the TypeScript compiler and minifier which wasn't handling ES6 well. But this is a work-in-progress. Committing here because this is a stable and working ES6 version.