Upgrade to 3.0 RTM packages and SDKs #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctyar
reviewed
Sep 23, 2019
global.json
Outdated
| @@ -1,5 +1,6 @@ | |||
| { | |||
| "sdk": { | |||
| "version": "3.0.100-preview9-014004" | |||
| "version": "3.0.100", | |||
| "rollForward": "latestFeature" | |||
There was a problem hiding this comment.
Is latestFeature a valid value here?
The docs only mention these:
Disable, LatestPatch, Minor, LatestMinor, Major, LatestMajor
There was a problem hiding this comment.
Good question! I'm honestly not sure - see https://github.com/dotnet/designs/pull/71/files#examples-of-usage which is still unclear. I'm okay with latestMajor anyway (and we can tweak this any time) - so let's go with that :)
Note the docs for CLI are not the same as global.json :)
I think this is what we want anyway, and docs are as yet unclear: https://github.com/dotnet/designs/pull/71/files#examples-of-usage ...so let's just go with it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bumps versioning off pre-release packages for the .NET Core 3.0 release today.