Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CreateDbDataReader should expose the originally requested CommandBehavior #362

Merged
merged 4 commits into from
Feb 12, 2019
Merged

CreateDbDataReader should expose the originally requested CommandBehavior #362

merged 4 commits into from
Feb 12, 2019

Conversation

mgravell
Copy link
Contributor

@mgravell mgravell commented Feb 12, 2019 •
edited
Loading

Context: subclasses of ProfiledDbCommand may need to be aware of the CommandBehavior if they are providing a custom subclass of ProfiledDbDataReader, especially if they want to perform connection status tracking such as closure tracking.

Change: add CommandBehavior behavior as a parameter into the CreateDbDataReader method, that has not been released in RTM form yet.

NickCraver
NickCraver approved these changes Feb 12, 2019
View reviewed changes
Copy link
Member

@NickCraver NickCraver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 👍

Note: this API never made it to NuGet (CreateDbDataReader), so we're doing a breaking change here.

@NickCraver NickCraver merged commit 2569114 into master Feb 12, 2019
@NickCraver NickCraver deleted the subreader-behavior branch July 19, 2019 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickCraver NickCraver NickCraver approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgravell @NickCraver