Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting PopupDecimalPlaces does not have any effect #652

Closed
nickmqb opened this issue Jun 15, 2023 · 0 comments · Fixed by #655
Closed

Setting PopupDecimalPlaces does not have any effect #652

nickmqb opened this issue Jun 15, 2023 · 0 comments · Fixed by #655

Comments

@nickmqb
Copy link

nickmqb commented Jun 15, 2023

Setting the PopupDecimalPlaces option does not have any effect on .NET Framework, ASP.NET MVC.

Looking at the code, it seems like the problem is with StackExchange.Profiling.Internal.Render.Includes() (2nd overload).
This overload does not emit the data-decimal-places attribute, whereas the first one does.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #652 - respect PopupDecimalPlaces in all cases MiniProfiler/dotnet
1 participant
@nickmqb