Made changes requested by yellis for readability and code cleanliness.

MiniProfiler · May 29, 2014 · 64ea0df · 64ea0df
1 parent 8607fe0
commit 64ea0df
Showing 1 changed file with 11 additions and 3 deletions.
diff --git a/StackExchange.Profiling/IpAddressProvider.cs b/StackExchange.Profiling/IpAddressProvider.cs
@@ -1,4 +1,5 @@
-using System.Web;
+using System;
+using System.Web;
 
 namespace StackExchange.Profiling
 {
@@ -16,8 +17,15 @@ public class IpAddressIdentity : IUserProvider
         /// </summary>
         public string GetUser(HttpRequest request)
         {
-            return string.Format("{0}, {1}", request.ServerVariables["REMOTE_ADDR"] ?? "",
-                                             request.ServerVariables["HTTP_X_FORWARDED_FOR"] ?? "");
+            // If there's no X_FORWARDED_FOR header, just return REMOTE_ADDR
+            if (String.IsNullOrWhiteSpace(request.ServerVariables["HTTP_X_FORWARDED_FOR"]))
+            {
+                return request.ServerVariables["REMOTE_ADDR"] ?? "";
+            }
+
+            // Otherwise return the concatenation of the REMOTE_ADDR and the X_FORWARDED_FOR header
+            return string.Format("{0} - {1}", request.ServerVariables["REMOTE_ADDR"] ?? "",
+                                              request.ServerVariables["HTTP_X_FORWARDED_FOR"]);
         }
     }
 }