Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

breaking: Redesign API #101

Merged
merged 5 commits into from
May 13, 2020
Merged

breaking: Redesign API #101

merged 5 commits into from
May 13, 2020

Conversation

singularitti
Copy link
Member

  1. Rename EquationOfState to EOSParameters, they are parameters, not a whole "EquationOfState"!
  2. Add type EquationOfState, taking an EOSParameters instance and apply on to a volume to get energy, pressure, bulk modulus, etc.
  3. Rewrite nonlinfit and fix tests

@singularitti singularitti added the breaking Introduce breaking changes label May 13, 2020
@singularitti singularitti merged commit 5ee5416 into develop May 13, 2020
@singularitti singularitti deleted the feature/api branch May 13, 2020 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking Introduce breaking changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@singularitti