New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional field tools to ASMAPI #61

Merged

LexManos merged 3 commits into MinecraftForge:master from Jonathing:feat/jonathing/master/field-tools

Nov 1, 2024

Member

Jonathing commented Nov 1, 2024

This PR aims to improve working with, and looking for, fields in method nodes.

Add buildFieldCall() to build field calls
Add findFirstFieldCall() and related methods to search for field calls
Add a buildMethodCall() sister that takes ASMAPI.MethodType as first parameter, mimicking the constructor to MethodInsnType and related methods in ASMAPI

Jonathing added 3 commits

November 1, 2024 09:37


          Add a buildMethodCall() with the type as first param

ae14c93

This mimics how MethodInsnNodes are created with the opcode being fed
first.


          Add findFirstFieldCall() methods to search for field calls

fdd6ccf


          Add buildFieldCall() to build field calls

dd76e9a

LexManos approved these changes

View reviewed changes

LexManos merged commit c95067a into MinecraftForge:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet