ASMAPI.getSystemPropertyFlag() checks the given property without only prepending "coremod." #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you not call Boolean.getBoolean directly in your coremod? Does this helper need to exist at all? |
|
java.lang is not allowed in the sandbox, so I can't invoke the Boolean wrapper class. |
|
Ah, ok, well then make implementation not call the old function, that way you dont have to change the logic of the old function. And it makes it easier to delete in the future. |
Jonathing
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successor to #41.
Previously,
ASMAPI.getSystemPropertyFlag()would prematurely prepend"coremod."to the string before checking it usingBoolean.getBoolean(). This PR retains that logic, but also checks if the string itself exists as a true property. The old logic contained has been deleted as it has been deprecated for removal since 5.0 and we are now at 5.1 (and who actually uses this except for me lmao).ASMAPI only checks if the given JVM property boolean is true, so there is no need to worry about "security" (aside from the fact that we're literally talking about Minecraft of all things) when it comes to getting properties.