Migrate to Swift 5️⃣.5️⃣ #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #250 +/- ##
==========================================
- Coverage 94.97% 92.01% -2.96%
==========================================
Files 99 99
Lines 3281 3281
==========================================
- Hits 3116 3019 -97
- Misses 165 262 +97
Continue to review full report at Codecov.
|
GH Actions' macOS 11 images have Xcode 13 available which means that Swift 5.5 is available to use in CI. https://github.com/actions/virtual-environments/blob/main/images/macos/macos-11-Readme.md#xcode ## Changes - Update `ci.yml`: + `DEVELOPER_DIR` to point to Xcode 13.2.1. + `IOS_SDK` to point to `iphonesimulator15.2`. + `PLATFORM_TARGET` to point to `x86_64-apple-ios15.2-simulator`. - Update Package.swift's `// swift-tools-version` to 5.5. - Update podspec's `swift_version` to 5.5. - Set Swift 5 version at the project level. - Update `carthage.sh` workaround for Carthage/Carthage#3019 to handle Xcode 13. - Update `README.md`.
p4checo
force-pushed
the
migrate-to-swift-5.5
branch
from
c7133c8
to
07711cd
Compare
filipe-lemos
approved these changes
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
masterMotivation and Context
GH Actions' macOS 11 images have Xcode 13 available which means that Swift 5.5 is available to use in CI.
macOS-11 image Xcode Reference
Description
Update
ci.yml:DEVELOPER_DIRto point to Xcode 13.2.1.IOS_SDKto point toiphonesimulator15.2.PLATFORM_TARGETto point tox86_64-apple-ios15.2-simulator.Update Package.swift's
// swift-tools-versionto 5.5.Update podspec's
swift_versionto 5.5.Set Swift 5 version at the project level.
Update
carthage.shworkaround for Carthage builds fail at xcrun lipo on Xcode 12 beta (3,4,5...) Carthage/Carthage#3019 to handle Xcode 13.Update
README.md.