Unify Release and CI workflows 🤝 #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #236 +/- ##
=======================================
Coverage 94.99% 94.99%
=======================================
Files 97 97
Lines 3296 3296
=======================================
Hits 3131 3131
Misses 165 165 Continue to review full report at Codecov.
|
diogoeiras
reviewed
May 12, 2021
Unfortunately, `workflow_run` triggers only capture the branch that triggered the workflow(s) they depend on, which means that we can't use them while filtering for tag pushes (which is what we want for triggering releases). That's why `startsWith(github.ref, 'refs/tags/')` was never `true` when the `Release` workflow ran. After quite a bit of experimentation and research, I came to the conclusion that we should just keep it simple (KISS and all that 🙈) and just unify our whole CI into a single workflow which easily achieves the setup we want. Hopefully third time will be the charm to get our releases working via GitHub Actions 🍀 ## Changes - Rename `Release` workflow jobs `deploy-github` and `deploy-cocoapods` to `release-github` and `release-cocoapods` respectively. - Move release workflow jobs to the `CI` Workflow, configured to only run on tag pushes (`X.Y.Z`) and with dependencies on `build-test`, `swiftpm`, `cocoapods` and `carthage` jobs.
p4checo
force-pushed
the
unify-release-workflow-into-ci
branch
from
3c74772
to
85c3c0e
Compare
filipe-lemos
approved these changes
May 12, 2021
diogoeiras
approved these changes
May 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
masterMotivation and Context
Unfortunately,
workflow_runtriggers only capture the branch that triggered the workflow(s) they depend on, which means that we can't use them while filtering for tag pushes (which is what we want for triggering releases). That's whystartsWith(github.ref, 'refs/tags/')was nevertruewhen theReleaseworkflow ran.After quite a bit of experimentation and research, I came to the conclusion that we should just keep it simple (KISS and all that 🙈) and just unify our whole CI into a single workflow which easily achieves the setup we want.
Hopefully third time will be the charm to get our releases working via GitHub Actions 🍀
Description
Rename
Releaseworkflow jobsdeploy-githubanddeploy-cocoapodstorelease-githubandrelease-cocoapodsrespectively.Move release workflow jobs to the
CIWorkflow, configured to only run on tag pushes (X.Y.Z) and with dependencies onbuild-test,swiftpm,cocoapodsandcarthagejobs.