Make url scheme and host match and register case insensitive #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JOCuendet
requested review from
p4checo,
diogoeiras,
filipe-lemos,
ivopintodasilva,
literallysofia,
nbarreto6 and
nqtavares
JOCuendet
changed the title
JOCuendet
changed the title
JOCuendet
force-pushed
the
feature/add-rfc3986-compliance
branch
from
cef2d5b
to
7bf4433
Compare
JOCuendet
changed the title
filipe-lemos
approved these changes
Oct 21, 2020
Codecov Report
@@ Coverage Diff @@
## master #222 +/- ##
=======================================
Coverage 94.84% 94.84%
=======================================
Files 97 97
Lines 3198 3200 +2
=======================================
+ Hits 3033 3035 +2
Misses 165 165
Continue to review full report at Codecov.
|
ricardomsm
approved these changes
Oct 21, 2020
literallysofia
approved these changes
Oct 22, 2020
nbarreto6
approved these changes
Oct 22, 2020
nqtavares
approved these changes
Oct 22, 2020
p4checo
requested changes
Oct 22, 2020
JOCuendet
changed the title
JOCuendet
changed the title
JOCuendet
changed the title
p4checo
approved these changes
Oct 22, 2020
Tests/AlicerceTests/DeepLinking/Route+TrieRouter_RouteTests.swift
Outdated
Show resolved
Hide resolved
diogoeiras
approved these changes
Oct 22, 2020
ivopintodasilva
approved these changes
Oct 22, 2020
JOCuendet
added a commit
that referenced
this pull request
Oct 23, 2020
Currently the mapping and register of url routes are case sensitive The RFC-3986 states that theses routes should be case insensitive - Add case insensitive url routes mapping and register logic - Add UnitTests to test, said logic - Conform to RFC-3986
nbarreto6
pushed a commit
that referenced
this pull request
Oct 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
masterMotivation and Context
The current implementation did not account for RFC-3986, and by doing so if the user entered an URL with a capital letters in the scheme or the host the match would fail.
By complying to the norm, this behaviour is now accounted for, and the issue is fixed.
Description
Forcing the scheme and host from the user's input URL to be lowercased before parsing them to the match method.
Changed a UnitTest to accommodate to the base code changes.
Tested applying the code to a working project and running the app on a physical device to debug the deep links and universal links