Add binary build and release workflow #77
Conversation
micxer
force-pushed
the
add-binary-build-and-release
branch
2 times, most recently
from
9a92e62
to
fe5155c
Compare
|
So, I should work as expected. I also fixed a bug in the checksumming. On a side note: I have no idea about rust and am working with github actions for the first time. Probably my DevOps background and countless hours with Jenkins helped a little 😆 |
|
|
||
| # - target: armv7-unknown-linux-musleabi | ||
| # os: ubuntu-latest | ||
| # name: prometheus_wireguard_exporter-armv7-unknown-linux-musleabi |
There was a problem hiding this comment.
Why is this one commented? 🤔
It's quite an important one, I think most arm devices are armv7 today
There was a problem hiding this comment.
I couldn't make this work. Any suggestion of someone more experienced with Rust and Cargo is welcome. My issue here is cross compiling ping. And from the looking around I'm not the only one having issues with that.
There was a problem hiding this comment.
🤔 I had the same issue when adding cross compiled Rust binaries for the Docker image and solved it somehow.. Now I don't remember how even when looking at my Dockerfile 😢
What's the error log you get? It's also rather strange you get the error for armv7 but not arm for example.
Regarding the apple-aarch64 I'm not sure since I'm not building it for Docker, so maybe it's another issue. But the Dockerfile is definitely building the binary for armv7-unknown-linux-musleabi so we should be able to solve it.
Cross.toml
Outdated
| @@ -0,0 +1,2 @@ | |||
| [target.x86_64-unknown-freebsd] | |||
| image = "docker.io/rustembedded/cross:x86_64-unknown-freebsd" | |||
There was a problem hiding this comment.
I'm not sure this is the same as .cargo/config.toml, but it might be. Maybe move that to https://github.com/MindFlavor/prometheus_wireguard_exporter/blob/master/.cargo/config.toml?
Would it be possible that the existing .cargo.config.yml conflicts with e.g. the armv7 build you're trying to achieve? 🤔
micxer
force-pushed
the
add-binary-build-and-release
branch
from
fe5155c
to
df7ac37
Compare
|
Nothing new here? @qdm12 anything missing? |
|
Let's merge as is, sorry I left this for so long, I got caught up in other stuff 😅 We can adjust with more PRs later down the line. |
This adds a workflow (or actually several parallel ones) that gets triggered for a new tag. It builds binaries for several different platforms, creates a release and attaches them as downloads. I wasn't able to make this work for arm64 (because of ring) therefore I commented that part for now.
You can have a look at my fork for how these releases will look like.
Fixes #59.