Check if block exists on S3Save - delegation backend performance improvement. #14918
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain your changes:
Prior the change there was a check in
S3Save
if particular item (submission or block) already exists on S3, however whether it existed or not, the item was overwritten anyway. The change only checks whether block exists, and if it does, it skips writing it to S3. I believe that the same check for the submission is not needed as it has a timestamp in the 'filename' so it will be always different.Explain how you tested your changes:
This change seem to significantly improve response times and memory usage of the application.
Load test has been performed prior and after applying the fix. Results gathered in the report: https://github.com/MinaFoundation/mina-delegation-program-tech/wiki/Load-Test-Report-2024%E2%80%9001%E2%80%9018
Checklist: