Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if block exists on S3Save - delegation backend performance improvement. #14918

Merged
merged 3 commits into from
Jan 24, 2024

Conversation

piotr-iohk
Copy link
Contributor

Explain your changes:

Prior the change there was a check in S3Save if particular item (submission or block) already exists on S3, however whether it existed or not, the item was overwritten anyway. The change only checks whether block exists, and if it does, it skips writing it to S3. I believe that the same check for the submission is not needed as it has a timestamp in the 'filename' so it will be always different.

Explain how you tested your changes:

This change seem to significantly improve response times and memory usage of the application.
Load test has been performed prior and after applying the fix. Results gathered in the report: https://github.com/MinaFoundation/mina-delegation-program-tech/wiki/Load-Test-Report-2024%E2%80%9001%E2%80%9018

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them
  • Closes #0000

@piotr-iohk piotr-iohk self-assigned this Jan 18, 2024
@georgeee georgeee self-requested a review January 18, 2024 18:58
Copy link
Member

@georgeee georgeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

log messages seem not to be adequate

@piotr-iohk piotr-iohk requested a review from georgeee January 19, 2024 08:22
@dkijania
Copy link
Member

!ci-build-me

@georgeee georgeee force-pushed the delegation-backend-perf-improvement branch from 21b7009 to c5d81c4 Compare January 24, 2024 10:32
@georgeee
Copy link
Member

!ci-build-me

@piotr-iohk piotr-iohk merged commit 5bdc968 into develop Jan 24, 2024
33 checks passed
@piotr-iohk piotr-iohk deleted the delegation-backend-perf-improvement branch January 24, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants