Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend/mina-signer: add 'jest' dev-dependency to run tests in CI #11175

Merged
merged 1 commit into from
Jun 3, 2022

Conversation

yorickvP
Copy link
Collaborator

@yorickvP yorickvP commented Jun 3, 2022

Explain your changes:

  • I'd like to run npm test in CI, which depends on jest. This commit adds the jest executable to the dev dependencies of mina-signer
    Explain how you tested your changes:
  • npm test

Checklist:

  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them

@yorickvP yorickvP added the Tweag label Jun 3, 2022
@yorickvP yorickvP requested a review from a team as a code owner June 3, 2022 13:37
@yorickvP yorickvP self-assigned this Jun 3, 2022
@yorickvP yorickvP added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Jun 3, 2022
@yorickvP yorickvP merged commit 27573b7 into compatible Jun 3, 2022
@yorickvP yorickvP deleted the tweag/signer-jest branch June 3, 2022 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants