Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a check for circulating supply address to transfer() #96

Merged

Conversation

kantp
Copy link
Collaborator

@kantp kantp commented Jul 18, 2024

Fixes #94.

@kantp kantp linked an issue Jul 18, 2024 that may be closed by this pull request
@kantp kantp force-pushed the 94-prevent-transfer-involving-the-circulating-supply-address branch from 06c930e to 5c54a14 Compare July 18, 2024 15:29
@kantp kantp marked this pull request as ready for review July 18, 2024 15:32
@kantp kantp force-pushed the 94-prevent-transfer-involving-the-circulating-supply-address branch from df53c70 to 32c531d Compare July 18, 2024 15:39
Copy link
Collaborator

@ymekuria ymekuria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -28,6 +28,20 @@ interface FungibleTokenDeployProps extends Exclude<DeployArgs, undefined> {
src: string
}

export const FungibleTokenErrors = {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that you abstracted these here.

@kantp kantp added this pull request to the merge queue Jul 19, 2024
Merged via the queue into main with commit 655a25d Jul 19, 2024
3 checks passed
@kantp kantp deleted the 94-prevent-transfer-involving-the-circulating-supply-address branch July 19, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent transfer() involving the circulating supply address
2 participants