Prevent account permissions for receive and access from being changed #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitschabaude
previously approved these changes
May 27, 2024
FungibleToken.ts
Outdated
Comment on lines
154
to
155
| this.checkZeroBalanceChange(updates) | ||
| this.forEachUpdate(updates, (update, _usesToken) => this.checkPermissionsUpdate(update)) |
There was a problem hiding this comment.
I would do it like the wMina example and combine the logic into a single call to this.forEachUpdate(). Stepping through the tree of account updates comes with a lot of overhead (hashing of account updates!), about 10k constraints IIRC, so it's better to do it just once
There was a problem hiding this comment.
Oh, that's a good point! I'll change that.
| @@ -423,6 +424,26 @@ describe("token integration", () => { | |||
| }) | |||
| }) | |||
|
|
|||
| describe("account permissions", () => { | |||
| it("should reject a transaction that's changing the account permission for receive", async () => { | |||
Doing one pass over the account updates instead of two
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.