Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PM-1694 - Add liminal manual chart #210

Merged
merged 1 commit into from
Jun 3, 2024
Merged

PM-1694 - Add liminal manual chart #210

merged 1 commit into from
Jun 3, 2024

Conversation

johnmarcou
Copy link
Collaborator

@johnmarcou johnmarcou commented May 29, 2024 •
edited
Loading

This PR declares the helm chart for liminal-manual.

Used here: https://argo-cd.minaprotocol.tools/applications/argo-cd/production-liminal-manual.

@johnmarcou johnmarcou self-assigned this May 29, 2024
@johnmarcou johnmarcou changed the title PM-1694 - Add liminal manual repository PM-1694 - Add liminal manual chart May 29, 2024
@johnmarcou johnmarcou force-pushed the jm-1694-liminal-doc-ecr branch 7 times, most recently from 6404743 to b4ba3e3 Compare May 30, 2024 14:43
@johnmarcou johnmarcou marked this pull request as ready for review May 30, 2024 16:44
Smorci
Smorci reviewed May 31, 2024
View reviewed changes
Copy link
Contributor

@Smorci Smorci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am only waiting on the response to the question of, why is is called -manual?

liminal-manual/templates/deployment.yaml Show resolved Hide resolved
liminal-manual/values.yaml Outdated Show resolved Hide resolved
@johnmarcou
Copy link
Collaborator Author

johnmarcou commented May 31, 2024 •
edited
Loading

I am only waiting on the response to the question of, why is is called -manual?

There is two repos:

For the latter, the initial name of the repo was https://github.com/MinaFoundation/liminalmanual.dev.git.
The repository only be renamed after we agreed on this URL liminal.minaprotocol.network, but it's still the liminal-manual.

@johnmarcou johnmarcou force-pushed the jm-1694-liminal-doc-ecr branch 2 times, most recently from f013211 to bde8962 Compare June 3, 2024 16:46
Smorci
Smorci approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@Smorci Smorci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@johnmarcou johnmarcou force-pushed the jm-1694-liminal-doc-ecr branch from bde8962 to bf13716 Compare June 3, 2024 22:26
@johnmarcou johnmarcou force-pushed the jm-1694-liminal-doc-ecr branch from bf13716 to 0dd783e Compare June 3, 2024 22:30
@johnmarcou johnmarcou merged commit 3c4e9d0 into main Jun 3, 2024
1 check passed
@johnmarcou johnmarcou deleted the jm-1694-liminal-doc-ecr branch June 3, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Smorci Smorci Smorci approved these changes

@simisimis simisimis Awaiting requested review from simisimis

@kaozenn kaozenn Awaiting requested review from kaozenn

Assignees

@johnmarcou johnmarcou

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnmarcou @Smorci